ada4355: Add idelay calibration functionality #1690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PIoandan
requested review from
acostina,
AndreiGrozav,
PopPaul2021,
gastmaier and
sarpadi
as code owners
Detect when it is encounter a frame or data error. Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@analog.com>
PIoandan
force-pushed
the
ada4355_idelay
branch
from
3c82949 to
8a42858
Compare
|
Register map updates should come with documentation updates |
PIoandan
requested review from
IuliaCMoldovan,
StancaPop and
LBFFilho
as code owners
Done. |
Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@analog.com>
IuliaCMoldovan
previously approved these changes
May 7, 2025
sarpadi
reviewed
May 7, 2025
Comment on lines
77
to
90
| if (up_rstn == 0) begin | ||
| up_rack <= 'd0; | ||
| up_rdata <= 'd0; | ||
| end else begin | ||
| up_rack <= up_rreq; | ||
| if (up_rreq == 1'b1) begin | ||
| case (up_raddr) | ||
| 7'h32: up_rdata <= {29'd0, up_enable_error}; | ||
| default: up_rdata <= 0; | ||
| endcase | ||
| end else begin | ||
| up_rdata <= 32'd0; | ||
| end | ||
| end |
| // processor write interface | ||
|
|
||
| always @(posedge up_clk) begin | ||
| if (up_rstn == 0) begin |
There was a problem hiding this comment.
indentation (hopefully it's not a TAB)
| @@ -351,6 +385,9 @@ module axi_ada4355_if #( | |||
| RESET : begin | |||
| shift_cnt <= 0; | |||
library/axi_ada4355/axi_ada4355_if.v
Outdated
| reg frame_err_r; | ||
| reg data_err_lane_0_r; | ||
| reg data_err_lane_1_r; | ||
| reg [15:0] lane_0_mask = 16'h5555; |
There was a problem hiding this comment.
these should be localparam, not reg
library/axi_ada4355/axi_ada4355_if.v
Outdated
| @@ -120,6 +124,7 @@ module axi_ada4355_if #( | |||
| reg [ 1:0] serdes_valid = 2'b00; | |||
| reg [ 1:0] serdes_valid_d = 2'b00; | |||
| reg [ 2:0] shift_cnt = 3'd0; | |||
| reg [ 4:0] delay = 5'd0; | |||
There was a problem hiding this comment.
you have a mix of "d", 'h" and "b" types. please use only one (preferably "h")
| @@ -275,38 +286,40 @@ module axi_ada4355_if #( | |||
| end | |||
Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@analog.com>
sarpadi
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Detect when it is encountering a frame or data error.
PR Type
PR Checklist